do not generate module files with DOWNLOAD_ONLY #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLartians
approved these changes
Mar 12, 2025
Member
TheLartians
left a comment
TheLartians
left a comment
There was a problem hiding this comment.
Thanks for the fix! I see how this can be confusing behaviour.
Perhaps might make sense to add a comment in another PR so future editors understand the reason the exception.
Member
|
Fix published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #649
Prevents calling
cpm_create_module_filewhenDOWNLOAD_ONLYwas set to true.I see no reason to generate module files, when you're just downloading a dependency.